Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): inactive surveys do not have active targeting flags #18664

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Nov 15, 2023

Problem

Inactive surveys should not have active targeting flags

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@liyiy liyiy requested a review from neilkakkar November 15, 2023 20:26
Copy link
Contributor

github-actions bot commented Nov 15, 2023

Size Change: +205 B (0%)

Total Size: 2.01 MB

Filename Size Change
frontend/dist/toolbar.js 2.01 MB +205 B (0%)

compressed-size-action

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good test! 👍

posthog/api/survey.py Outdated Show resolved Hide resolved
posthog/api/survey.py Outdated Show resolved Hide resolved
posthog/api/survey.py Outdated Show resolved Hide resolved
posthog/api/survey.py Outdated Show resolved Hide resolved
@liyiy liyiy merged commit a7c51d0 into master Nov 16, 2023
67 checks passed
@liyiy liyiy deleted the disable-completed-survey-flags branch November 16, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants