Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Add staleness check and update warning #18660

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Nov 15, 2023

Problem

https://posthog.slack.com/archives/C03JJKLEC8L/p1700061413856629?thread_ts=1700056233.185239&cid=C03JJKLEC8L

Changes

  • Don't just check that the $pageleave/$pageview events have ever been sent, check that they have also been sent recently (I just used the staleness constant we already had, but might want to shorten this if it turns out to be too long).
  • Change the error messages to include more relevant docs.

New error screenshots (ignore the fact that there obviously are pageviews)
Screenshot 2023-11-15 at 20 35 04
Screenshot 2023-11-15 at 20 34 06
Screenshot 2023-11-15 at 20 34 26

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Ran it manually

@robbie-c robbie-c changed the title Add staleness check and update warning feat(web-analytic):Add staleness check and update warning Nov 15, 2023
@robbie-c robbie-c changed the title feat(web-analytic):Add staleness check and update warning feat(web-analytics):Add staleness check and update warning Nov 15, 2023
@robbie-c robbie-c changed the title feat(web-analytics):Add staleness check and update warning feat(web-analytics): Add staleness check and update warning Nov 15, 2023
@robbie-c robbie-c force-pushed the add-staleness-check-and-update-warning branch from 0f95ff2 to fa88233 Compare November 15, 2023 20:29
@robbie-c robbie-c force-pushed the add-staleness-check-and-update-warning branch from fa88233 to 17d458e Compare November 15, 2023 20:32
Copy link
Contributor

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@robbie-c robbie-c marked this pull request as ready for review November 16, 2023 09:57
@robbie-c robbie-c merged commit 0c9bd8d into master Nov 16, 2023
80 checks passed
@robbie-c robbie-c deleted the add-staleness-check-and-update-warning branch November 16, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants