Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow switching timing view #18647

Merged
merged 4 commits into from
Nov 15, 2023
Merged

feat: allow switching timing view #18647

merged 4 commits into from
Nov 15, 2023

Conversation

pauldambra
Copy link
Member

Problem

With the new mini waterfall view if there is no data you can't see why...

Changes

Allow people to switch between table and timeline view for the timing data

How did you test this code?

👀 locally

2023-11-15 12 06 05

@pauldambra pauldambra requested a review from a team November 15, 2023 12:12
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not :D

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra enabled auto-merge (squash) November 15, 2023 12:24
@pauldambra pauldambra merged commit 3332f86 into master Nov 15, 2023
74 checks passed
@pauldambra pauldambra deleted the feat/switch-timing-view branch November 15, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants