Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace all antd tooltips #18638

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: replace all antd tooltips #18638

merged 1 commit into from
Nov 15, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 15, 2023

Problem

We have a class in Posthog for tooltips

Changes

  • Remove all usages of antd Tooltips
  • Add a linting rule to prevent regressions

How did you test this code?

Linting rule

@daibhin daibhin requested a review from a team November 15, 2023 12:06
thmsobrmlr
thmsobrmlr approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice 🙌 Didn't check all usages, but trust you did.

@daibhin daibhin merged commit 71da4c7 into master Nov 15, 2023
74 checks passed
@daibhin daibhin deleted the dn/replace-all-antd-tooltips branch November 15, 2023 12:15
pauldambra pushed a commit that referenced this pull request Nov 15, 2023
@daibhin @pauldambra
chore: replace all antd tooltips (#18638)
c1436c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @thmsobrmlr