Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): project switcher and mobile friendly #18634

Merged
merged 14 commits into from
Nov 15, 2023

Conversation

raquelmsmith
Copy link
Member

@raquelmsmith raquelmsmith commented Nov 15, 2023

Problem

New onboarding flows were not mobile friendly, but to roll it out fully they should be. We also need the project switcher in the nav before rolling out.

Changes

Adds project switcher to nav
image

And makes all the steps mobile friendly

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

This is all behind a flag and therefore tedious to test.. will add stories after it's no longer behind a flag.

@raquelmsmith raquelmsmith marked this pull request as ready for review November 15, 2023 01:29
@raquelmsmith raquelmsmith requested a review from xrdt November 15, 2023 01:29
@raquelmsmith raquelmsmith enabled auto-merge (squash) November 15, 2023 18:44
Copy link
Contributor

github-actions bot commented Nov 15, 2023

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@raquelmsmith raquelmsmith merged commit 422e8f8 into master Nov 15, 2023
73 checks passed
@raquelmsmith raquelmsmith deleted the feat/onboarding-fixes branch November 15, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant