fix(surveys): enable button text per question instead #18623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
neilkakkar
approved these changes
Nov 14, 2023
neilkakkar
reviewed
Nov 14, 2023
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
liyiy
force-pushed
the
fix-nxt-submit-btns
branch
from
f1e3c07 to
fe283aa
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
liyiy
force-pushed
the
fix-nxt-submit-btns
branch
from
66a5566 to
2731116
Compare
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
pauldambra
pushed a commit
that referenced
this pull request
Nov 15, 2023
* add button text field to question * clean up last traces of new surveys with submitButtonText * button text * fix empty string bug * clean up * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We only had 1 field to set up a "submit button text" value, which doesn't work for multiple question surveys.
Changes
PostHog/posthog-js#893
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?