fix(exports): breakdown limit #18597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
pushed a commit
that referenced
this pull request
Nov 15, 2023
Use the breakdown limit in the query params for the next page if it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
breakdown_limitas the result limit from the insights api response. But this is then ignored when building the pagination url, and instead, the default limit of 25 is used. This means we duplicated results in the CSV files when there were more than 25 breakdown valuesChanges
breakdown_limitparam from the query string when it exists instead of the defaultlimitfor the pagination url of insightsHow did you test this code?
Recreating the issue and exporting locally with the correct results