Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unsubscribe survey typo #18585

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix: fix unsubscribe survey typo #18585

merged 3 commits into from
Nov 16, 2023

Conversation

xrdt
Copy link
Contributor

@xrdt xrdt commented Nov 13, 2023

Problem

There was a typo in the logic for checking whether the survey response was empty that was causing us to send 'survey dismissed' instead of 'survey sent' events.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@xrdt xrdt requested a review from raquelmsmith November 13, 2023 20:42
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 should we do a cypress test for this to make sure it actually works as we expect?

Copy link
Contributor

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@xrdt xrdt merged commit 558661e into master Nov 16, 2023
70 checks passed
@xrdt xrdt deleted the by/survey_broken branch November 16, 2023 00:04
@xrdt
Copy link
Contributor Author

xrdt commented Nov 16, 2023

🙈 should we do a cypress test for this to make sure it actually works as we expect?

Tabled the cypress testing for now as it's not quite obvious how to intercept posthog.capture calls from posthog. Slack thread: https://posthog.slack.com/archives/C0113360FFV/p1699982765367859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants