Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dark mode/display on load #18583

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

smallbrownbike
Copy link
Contributor

Changes

  • Posts a message to the posthog.com iframe when the theme is toggled (the theme is then toggled within the iframe as well)
  • Hides iframe until a ready message is received (this should fix the nav flicker issue)
  • Updates the message type logic to support the new format in this PR

@posthog-bot
Copy link
Contributor

Hey @smallbrownbike! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of tweaks to have a better loading state and not to muddy the themeLogic but this is awesome!

@benjackwhite benjackwhite merged commit b4a8093 into feat/sidepanel-docs Nov 14, 2023
46 of 47 checks passed
@benjackwhite benjackwhite deleted the feat/sidepanel-docs-additions branch November 14, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants