fix: Fail backfill on schedule deletion #18575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
fix/stop-backfill-on-schedule-delete
branch
2 times, most recently
from
5e8a7d2 to
3ec7050
Compare
tomasfarias
force-pushed
the
fix/stop-backfill-on-schedule-delete
branch
from
3ec7050 to
80ad7b2
Compare
tomasfarias
requested review from
bretthoerner and
a team
and removed request for
bretthoerner
bretthoerner
approved these changes
Nov 14, 2023
pauldambra
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix: Fail backfill on schedule deletion * fix: Check first that a schedule exists * fix: Do not retry on TemporalScheduleNotFoundError * fix: Assume schedule deleted only with NOT_FOUND status
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Backfills are not cleaned up properly when deleting an export. If a backfill is still running, it should stop if it's underlying schedule (batch export) is deleted.
Changes
TemporalScheduleNotFoundErrorif we cannot get the schedule while waiting on the backfill runs.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added unit tests.