Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(3000): 3000 colors #18545

Merged
merged 184 commits into from
Nov 20, 2023
Merged

feat(3000): 3000 colors #18545

merged 184 commits into from
Nov 20, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 10, 2023 •
edited
Loading

Problem

Orange is the new blue

Changes

Changes blues to orange / yellow

Light Dark
Screenshot 2023-11-17 at 20 01 18 Screenshot 2023-11-17 at 20 01 25

How did you test this code?

  • Double checked all the snapshots
  • Clicked around on the legacy UI to make sure we hadn't broken anything

corywatilo and others added 30 commits November 8, 2023 20:20
@corywatilo
secondary button in dark mode
3cd1fae
@corywatilo
secondary button in light mode
92285d9
@corywatilo
styles for normal sized buttons
f7ce05d
@corywatilo
don't force buttons to be full width (and also let event buttons be i…
c164994 
…nline!)

https://capture.dropbox.com/6Q2hUkSyWC2jdHVf
@corywatilo
move padding to its own class
59e9f01
@corywatilo
primary button spacing polish
1202a68
@corywatilo
nuking stealth styles
cd520b7
@corywatilo
styled navbar buttons
81b06f9
@corywatilo
primary button colors in dark mode
7a3dd72
@corywatilo
container for buttons in date range, min-heights for buttons
a4a44f6
@corywatilo
selected button background color
e4c9915
@corywatilo
active button positioning when hovered
448b273
@corywatilo
fixed primary active background
9eaf98b
@corywatilo
navbar hover state
49a1b53
@corywatilo
fixing one thing but probably breaking something else (can't remember)
6dd9b65
@corywatilo
merge conflicts, remove clang
d9a21d2
@github-actions
Update UI snapshots for webkit (2)
bb22b94
@github-actions
Update UI snapshots for chromium (2)
0f96e12
@github-actions
Update UI snapshots for chromium (1)
b23f162
@github-actions
Update UI snapshots for chromium (2)
ddda468
@github-actions
Update UI snapshots for webkit (2)
939dde8
@github-actions
Update UI snapshots for chromium (2)
665a4b5
@github-actions
Update UI snapshots for webkit (2)
95beb1d
@github-actions
Update UI snapshots for chromium (1)
507d812
@corywatilo
resize nav
4bfbcc0
@github-actions
Update UI snapshots for chromium (1)
b719cfa
@corywatilo
fixed dropdown button stylin
a9270b0
@corywatilo
Merge branch 'buttons-3000' of https://github.com/PostHog/posthog int…
032368c 
…o buttons-3000
@github-actions
Update UI snapshots for chromium (1)
75394f7
@github-actions
Update UI snapshots for chromium (1)
39861c0
@daibhin daibhin force-pushed the dn-feat/link-colors branch from f364344 to b7d16cd Compare November 17, 2023 19:56
@daibhin daibhin marked this pull request as ready for review November 17, 2023 20:04
@daibhin daibhin enabled auto-merge (squash) November 17, 2023 20:04
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

40 snapshot changes in total. 0 added, 40 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@corywatilo corywatilo self-requested a review November 17, 2023 20:06
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

41 snapshot changes in total. 0 added, 41 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin force-pushed the dn-feat/link-colors branch from 6150a4f to 6acc6ee Compare November 20, 2023 11:31
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

40 snapshot changes in total. 0 added, 40 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit 0bbd150 into master Nov 20, 2023
73 checks passed
@daibhin daibhin deleted the dn-feat/link-colors branch November 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corywatilo corywatilo corywatilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@daibhin @posthog-bot @corywatilo @robbie-c @raquelmsmith @jurajmajerik @neilkakkar @mariusandra @thmsobrmlr @tomasfarias