feat: Pipeline UI App tabs with logs view #18527
Conversation
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
tiina303
requested review from
a team,
mariusandra,
Twixes and
thmsobrmlr
and removed request for
mariusandra
tiina303
force-pushed
the
pipeline-ui-transformations
branch
5 times, most recently
from
9704660 to
5984a99
Compare
tiina303
force-pushed
the
pipeline-ui-transf-single-page
branch
from
1745022 to
7a2e3f4
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
frontend/__snapshots__/scenes-app-pipeline--pipeline-app-configuration.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Not strictly part of this PR, but stumbled into it here. Imo it would be great to wrap the logs in something like the following to preserver whitespace and make it look more like code:
render: (message: string) => <code className="whitespace-pre">{message}</code>,
There was a problem hiding this comment.
I couldn't figure this out I tried whitespace-pre-wrap which helped as now the result wasn't just a single line if I printed out the whole event, but it was still too long, so break-all helped, but then it also broke in the middle of the words, which isn't great.
|
Size Change: -2.21 kB (0%) Total Size: 2.01 MB
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
The single app view would allow editing the app config, viewing metrics and logs.
See storybook images in the files for what things look like.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?