feat: Update Activation Call to Include Billing Limit #18498
Conversation
|
Hey @xrdt! 👋 |
xrdt
force-pushed
the
by/billing-limit-on-subscribe-warehouse
branch
from
aad0a60 to
ecd66ea
Compare
xrdt
force-pushed
the
by/billing-limit-on-subscribe-warehouse
branch
from
ecd66ea to
e5abe42
Compare
| @@ -258,8 +258,6 @@ export const onboardingLogic = kea<onboardingLogicType>([ | |||
| } | |||
| if (step) { | |||
| actions.setStepKey(step) | |||
| } else { | |||
| actions.resetStepKey() | |||
There was a problem hiding this comment.
Removing seems to fix some weird bug in the /products onboarding flow where I have to click on "set up again" twice to get the next page to show up. I'm not entirely sure why this works...
Here's a before video:
Screen.Recording.2023-11-09.at.3.17.24.PM.mp4
And after video:
Screen.Recording.2023-11-09.at.3.18.56.PM.mp4
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
I think we don't need this since it's handled on the billing side now correct? |
Problem
Tested manually against product_analytics:
Screen.Recording.2023-11-09.at.3.20.46.PM.mp4
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?