Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build unit docker image so we can build on arm #18492

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Nov 8, 2023

Problem

We were using the unit 1.28-python3.10 image before. The unit python3.11 image is available on arm but 3.10 only on amd64. Build it ourself so that we can use arm and also latest unit on 3.10

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

We were using the unit 1.28-python3.10 image before. The unit python3.11
image is available on arm but 3.10 only on amd64. Build it ourself so that
we can use arm and also latest unit on 3.10
@frankh frankh requested a review from ellie November 8, 2023 16:39
@frankh frankh merged commit a381131 into master Nov 8, 2023
68 of 69 checks passed
@frankh frankh deleted the frank/unit-build branch November 8, 2023 17:23
@frankh frankh restored the frank/unit-build branch November 21, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants