Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change notice tooltips easier to close #18489

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

benjackwhite
Copy link
Contributor

Problem

Apparently it wasn't super obvious - now clicking anywhere will dismiss it and it is an X icon

Changes

Screenshot 2023-11-08 at 17 17 21

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested review from mariusandra and a team November 8, 2023 16:17
@benjackwhite benjackwhite enabled auto-merge (squash) November 8, 2023 16:18
@benjackwhite benjackwhite changed the title Fixed tooltips to be easier to close fix: Change notice tooltips easier to close Nov 8, 2023
@benjackwhite benjackwhite disabled auto-merge November 8, 2023 16:18
@benjackwhite benjackwhite enabled auto-merge (squash) November 8, 2023 16:18
@benjackwhite benjackwhite disabled auto-merge November 8, 2023 16:29
@benjackwhite benjackwhite merged commit 0b0a29a into master Nov 8, 2023
65 of 66 checks passed
@benjackwhite benjackwhite deleted the fix/easier-dismiss branch November 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants