Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: :team_id isn't the path any more #18485

Merged
merged 3 commits into from
Nov 8, 2023
Merged

fix: :team_id isn't the path any more #18485

merged 3 commits into from
Nov 8, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 8, 2023 •
edited
Loading

follow-up to #18436

I'm not clear on what happened but we still have references to the :team_id path

see: https://github.com/PostHog/posthog/actions/runs/6798221708

@thmsobrmlr thmsobrmlr self-requested a review November 8, 2023 13:56
thmsobrmlr
thmsobrmlr approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was cause by two conflicting PRs: one move the folder, the other one added a file to it. Thanks for the fix!

@benjackwhite benjackwhite merged commit a6fccbe into master Nov 8, 2023
74 checks passed
@benjackwhite benjackwhite deleted the fix/team_id_mock_path branch November 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldambra @thmsobrmlr @benjackwhite