Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notebooks insight bugs #18483

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix: notebooks insight bugs #18483

merged 4 commits into from
Nov 8, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 8, 2023

Problem

Covers two issues pointed out in Slack

  1. Timings show up on data table nodes
  2. Clicking "Add to notebook" on an insight adds a random insight

Changes

  1. Set the showTimings flag to false for data table nodes
  2. We rely on the attrs in a resource to create the node. I removed it in fix: show correct badge count on notebook button #17735 to fix a different bug where the search results because the id attr was expected which a query node does not have (only attr is query).

How did you test this code?

Manually

@daibhin daibhin merged commit 66dd961 into master Nov 8, 2023
73 checks passed
@daibhin daibhin deleted the dn-fix/notebooks-insights branch November 8, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants