feat(feature flags): use organization flags API in the UI #18477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Neil Kakkar <[email protected]>
…g/posthog into fix/feature-flags-filters
…feature-flags-filters
…g/posthog into fix/feature-flags-filters
…feature-flags-filters
neilkakkar
approved these changes
Nov 8, 2023
| copyFlag: async () => { | ||
| const orgId = values.currentOrganization?.id | ||
|
|
||
| return await api.create(`api/organizations/${orgId}/feature_flags/copy_flags`, { |
There was a problem hiding this comment.
don't create the api path like so, instead add the copy_flags path here: https://github.com/PostHog/posthog/blob/master/frontend/src/lib/api.ts#L165
for an example see: https://github.com/PostHog/posthog/blob/master/frontend/src/scenes/feature-flags/featureFlagLogic.ts#L484
…g/posthog into fix/feature-flags-filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screen.Recording.2023-11-08.at.10.25.50.mov
Follow ups:
copy_flagsendpoint accepts multiple flagsSuggest de-prio for now:
How did you test this code?
👀