Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-server): send only elementsChain to webhooks #18468

Closed
wants to merge 1 commit into from
Closed

feat(plugin-server): send only elementsChain to webhooks #18468

wants to merge 1 commit into from

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Nov 7, 2023 •
edited
Loading

Problem

In an attempt to get #17042 reviewable and mergeable, I took the step of removing the needless elementsList creation in the plugin server.

Changes

  • Updates PostIngestionEvent to store original the elementsChain, instead of transforming it into elementsList.
  • This event is sent to webhook matching, and will convert the chain back to the list if requested.

How did you test this code?

TODO. Many CI failures.

@mariusandra
Copy link
Collaborator Author

Going to close it and wait for similar work in #18465 to complete

@mariusandra mariusandra closed this Nov 8, 2023
@mariusandra mariusandra deleted the plugin-server-events-tweaks branch November 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mariusandra