Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing modals for 3000 #18453

Merged
merged 3 commits into from
Nov 8, 2023
Merged

fix: Missing modals for 3000 #18453

merged 3 commits into from
Nov 8, 2023

Conversation

benjackwhite
Copy link
Contributor

Problem

We were missing some modals for the 3000 breadcrumbs. This meant you can't create a new project / org

Changes

  • Created a global component for this. It's not pretty but it works for now

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested review from Twixes and a team November 7, 2023 16:39
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit 9ffba57 into master Nov 8, 2023
73 checks passed
@benjackwhite benjackwhite deleted the fix/missing-modals branch November 8, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants