chore(django): report django_surrogates_substituted_total metric #18449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
capture.py detects and removes utf16 surrogates, that could happen if a string is improperly truncated. Let's add a metric to measure how often we receive this kind of payloads, and whether we can just 400 on new capture.
Adding a single
surrogates_substituted_totalmetric for both django and plugin-server, we'll query it sliced byrole.Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?