Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): restore form #18429

Merged
merged 6 commits into from
Nov 6, 2023
Merged

chore(data-warehouse): restore form #18429

merged 6 commits into from
Nov 6, 2023

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 6, 2023

Problem

  • onboarding panel links to the wrong form

Changes

  • bring back the external data form and make sure links are correct

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @EDsCODE! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@EDsCODE EDsCODE merged commit df16d5b into master Nov 6, 2023
71 of 72 checks passed
@EDsCODE EDsCODE deleted the dw-restore-form branch November 6, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants