feat(web-analytics): Use person properties for web analytics source #18423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
robbie-c
changed the title
robbie-c
force-pushed
the
use-person-properties-for-web-analytics-source
branch
from
de0f28e to
467c145
Compare
robbie-c
force-pushed
the
use-person-properties-for-web-analytics-source
branch
from
467c145 to
9389bdd
Compare
|
Hey @robbie-c! 👋 |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
robbie-c
force-pushed
the
use-person-properties-for-web-analytics-source
branch
from
ab235c8 to
79bcea2
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
mariusandra
approved these changes
Nov 8, 2023
robbie-c
force-pushed
the
use-person-properties-for-web-analytics-source
branch
from
e4529f1 to
ea6da9f
Compare
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ideally we would use these client-session params, however due to PostHog/posthog-js#876 these don't work very well at the moment. Instead, just use person properties for now. This will be slower, but acceptable for the time being, and unblocks releasing this to more people.
Changes
How did you test this code?
Manually tested, I also did #18424