Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Settings 3000 #18419

Merged
merged 65 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
403614e
Started adding new settings scene
benjackwhite Nov 6, 2023
9cf60e0
Fixed up settings
benjackwhite Nov 6, 2023
75657a7
Added more settings
benjackwhite Nov 6, 2023
c97ebc1
Fix
benjackwhite Nov 6, 2023
691f0b1
Fix
benjackwhite Nov 6, 2023
9f194ef
More refactoring
benjackwhite Nov 6, 2023
2da1c58
Added more settings
benjackwhite Nov 6, 2023
f9813a7
Fixed up settings
benjackwhite Nov 6, 2023
1b9eeb7
Fixes
benjackwhite Nov 6, 2023
dfa11fb
Added redirects
benjackwhite Nov 6, 2023
529e0c9
Fixed up settings
benjackwhite Nov 6, 2023
617e1b6
Removed old settings
benjackwhite Nov 7, 2023
11a4b05
Removed more
benjackwhite Nov 7, 2023
be49edc
Fixed up logics
benjackwhite Nov 7, 2023
344acd9
Fix
benjackwhite Nov 7, 2023
b21564e
Fix
benjackwhite Nov 7, 2023
ee0d96c
Added settings side panel
benjackwhite Nov 7, 2023
599b4b9
Fix up settings rendering
benjackwhite Nov 7, 2023
2e7fc31
Fixes
benjackwhite Nov 7, 2023
4df6e6c
Fixed up mobile mode
benjackwhite Nov 7, 2023
6a9f1a2
Fix up for settings
benjackwhite Nov 7, 2023
614060d
Fixed up settings
benjackwhite Nov 7, 2023
e0228ac
fix
benjackwhite Nov 7, 2023
de6976e
Fix settings
benjackwhite Nov 7, 2023
9de7048
Fixed not found
benjackwhite Nov 7, 2023
56874a7
Fixes
benjackwhite Nov 7, 2023
9b72051
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 7, 2023
fb66557
Fixed
benjackwhite Nov 7, 2023
4de7bea
Fix
benjackwhite Nov 7, 2023
c7f4d2c
Fix
benjackwhite Nov 7, 2023
b876f6a
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 7, 2023
ffc2215
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 7, 2023
4b47c76
Fixed test
benjackwhite Nov 7, 2023
a992222
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 7, 2023
b7aff40
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 7, 2023
1f0fc2d
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 7, 2023
7637eb0
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 7, 2023
c2892c0
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 7, 2023
c8a4b40
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 7, 2023
d3db572
PR review fixes
benjackwhite Nov 7, 2023
9f9c7f8
Fixed activation sidebar
benjackwhite Nov 7, 2023
53758f8
Merge branch 'feat/settings-3000' of github.com:PostHog/posthog into …
benjackwhite Nov 7, 2023
e4da73b
Added stories for settings
benjackwhite Nov 7, 2023
7ae2807
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 8, 2023
f96b56c
Fix
benjackwhite Nov 8, 2023
4e3751a
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 8, 2023
0146b86
Fixed up initial size
benjackwhite Nov 8, 2023
6734c1c
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 8, 2023
60315fe
Fix
benjackwhite Nov 8, 2023
e86ccf1
Merge branch 'feat/settings-3000' of github.com:PostHog/posthog into …
benjackwhite Nov 8, 2023
bed20fa
Fix
benjackwhite Nov 8, 2023
dbf345f
Fix
benjackwhite Nov 8, 2023
4f1de92
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 8, 2023
209b9e7
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 8, 2023
52f1858
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 8, 2023
2454cfe
Update UI snapshots for `webkit` (2)
github-actions[bot] Nov 8, 2023
b404c08
Update UI snapshots for `webkit` (2)
github-actions[bot] Nov 8, 2023
e141482
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 8, 2023
86eca1b
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 8, 2023
af924e3
Merge branch 'master' into feat/settings-3000
benjackwhite Nov 9, 2023
5fb9bd4
Merge branch 'feat/settings-3000' of github.com:PostHog/posthog into …
benjackwhite Nov 9, 2023
d6a1405
Fixed up modals
benjackwhite Nov 9, 2023
509ce6b
Fix
benjackwhite Nov 9, 2023
de17111
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 9, 2023
9192fc4
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/layout/navigation/ProjectNotice.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useActions, useValues } from 'kea'
import { Link } from 'lib/lemon-ui/Link'
import { navigationLogic, ProjectNoticeVariant } from './navigationLogic'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { LemonBanner } from 'lib/lemon-ui/LemonBanner'
import { IconPlus, IconSettings } from 'lib/lemon-ui/icons'
import { LemonBannerAction } from 'lib/lemon-ui/LemonBanner/LemonBanner'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/layout/navigation/TopBar/SitePopover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
NewOrganizationButton,
OtherOrganizationButton,
} from '~/layout/navigation/OrganizationSwitcher'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { Tooltip } from 'lib/lemon-ui/Tooltip'
import { LemonButtonPropsBase } from '@posthog/lemon-ui'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/layout/navigation/TopBar/TopBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import { navigationLogic } from '../navigationLogic'
import { HelpButton } from 'lib/components/HelpButton/HelpButton'
import { CommandPalette } from 'lib/components/CommandPalette'
import { CreateOrganizationModal } from 'scenes/organization/CreateOrganizationModal'
import { InviteModal } from 'scenes/organization/Settings/InviteModal'
import { InviteModal } from 'scenes/settings/organization/InviteModal'
import { Link } from 'lib/lemon-ui/Link'
import { IconMenu, IconMenuOpen } from 'lib/lemon-ui/icons'
import { CreateProjectModal } from 'scenes/project/CreateProjectModal'
import './TopBar.scss'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { UniversalSearchPopover } from 'lib/components/UniversalSearch/UniversalSearchPopover'
import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'
import { groupsModel } from '~/models/groupsModel'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/layout/navigation/navigationLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { sceneLogic } from 'scenes/sceneLogic'
import { teamLogic } from 'scenes/teamLogic'
import { userLogic } from 'scenes/userLogic'
import type { navigationLogicType } from './navigationLogicType'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { Scene } from 'scenes/sceneTypes'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expectLogic } from 'kea-test-utils'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { pluginsLogic } from 'scenes/plugins/pluginsLogic'
import { teamLogic } from 'scenes/teamLogic'
import { navigationLogic } from '~/layout/navigation/navigationLogic'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { loaders } from 'kea-loaders'
import { router, urlToAction } from 'kea-router'
import api from 'lib/api'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { pluginsLogic } from 'scenes/plugins/pluginsLogic'
import { teamLogic } from 'scenes/teamLogic'
import { navigationLogic } from '~/layout/navigation/navigationLogic'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { DashboardType, InsightType } from '~/types'
import api from 'lib/api'
import { copyToClipboard, isMobile, isURL, sample, uniqueBy } from 'lib/utils'
import { userLogic } from 'scenes/userLogic'
import { personalAPIKeysLogic } from '../PersonalAPIKeys/personalAPIKeysLogic'
import { personalAPIKeysLogic } from '../../../scenes/settings/user/personalAPIKeysLogic'
import { teamLogic } from 'scenes/teamLogic'
import posthog from 'posthog-js'
import { debugCHQueries } from './DebugCHQueries'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { Owner } from 'scenes/events/Owner'
import { dayjs } from 'lib/dayjs'
import { Divider, DividerProps, Select } from 'antd'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { Link } from 'lib/lemon-ui/Link'
import { Tooltip } from 'lib/lemon-ui/Tooltip'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
Expand Down Expand Up @@ -188,7 +188,7 @@

function HorizontalLine({ children, ...props }: DividerProps): JSX.Element {
return (
<Divider className="definition-popover-divider" {...props}>

Check warning on line 191 in frontend/src/lib/components/DefinitionPopover/DefinitionPopover.tsx

View workflow job for this annotation

GitHub Actions / Code quality checks

<Divider> is forbidden, use <LemonDivider> instead
{children}
</Divider>
)
Expand Down Expand Up @@ -252,7 +252,7 @@
const { setLocalDefinition } = useActions(definitionPopoverLogic)

return (
<Select

Check warning on line 255 in frontend/src/lib/components/DefinitionPopover/DefinitionPopover.tsx

View workflow job for this annotation

GitHub Actions / Code quality checks

<Select> is forbidden, use <LemonSelect> instead
className={'definition-popover-owner-select definition-popover-edit-form-value'}
placeholder={<Owner user={'owner' in localDefinition ? localDefinition?.owner : null} />}
style={{ minWidth: 200 }}
Expand Down
1 change: 0 additions & 1 deletion frontend/src/lib/components/PersonalAPIKeys/index.tsx

This file was deleted.

23 changes: 16 additions & 7 deletions frontend/src/lib/components/RestrictedArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,16 @@ export enum RestrictionScope {
Project = 'project',
}

export interface RestrictedAreaProps {
Component: (props: RestrictedComponentProps) => JSX.Element
export interface UseRestrictedAreaProps {
minimumAccessLevel: EitherMembershipLevel
scope?: RestrictionScope
}

export function RestrictedArea({
Component,
minimumAccessLevel,
scope = RestrictionScope.Organization,
}: RestrictedAreaProps): JSX.Element {
export interface RestrictedAreaProps extends UseRestrictedAreaProps {
Component: (props: RestrictedComponentProps) => JSX.Element
}

export function useRestrictedArea({ scope, minimumAccessLevel }: UseRestrictedAreaProps): null | string {
const { currentOrganization } = useValues(organizationLogic)
const { currentTeam } = useValues(teamLogic)

Expand Down Expand Up @@ -59,6 +58,16 @@ export function RestrictedArea({
return null
}, [currentOrganization])

return restrictionReason
}

export function RestrictedArea({
Component,
minimumAccessLevel,
scope = RestrictionScope.Organization,
}: RestrictedAreaProps): JSX.Element {
const restrictionReason = useRestrictedArea({ minimumAccessLevel, scope })

return restrictionReason ? (
<Tooltip title={restrictionReason} placement="topLeft" delayMs={0}>
<span>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useEffect, useMemo } from 'react'
import { useActions, useValues } from 'kea'
import { LemonButton } from 'lib/lemon-ui/LemonButton'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic'
import { Field } from 'lib/forms/Field'
import { dayjs } from 'lib/dayjs'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { inAppPromptLogic } from 'lib/logic/inAppPrompt/inAppPromptLogic'
import { SpinnerOverlay } from 'lib/lemon-ui/Spinner/Spinner'
import { LemonModal } from '@posthog/lemon-ui'
import { Setup2FA } from './authentication/Setup2FA'
import { membersLogic } from './organization/Settings/membersLogic'
import { membersLogic } from './settings/organization/membersLogic'
import { FEATURE_FLAGS } from 'lib/constants'
import { Navigation as Navigation3000 } from '~/layout/navigation-3000/Navigation'
import { Prompt } from 'lib/logic/newPrompt/Prompt'
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/ResourcePermissionModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import {
FormattedResourceLevel,
permissionsLogic,
ResourcePermissionMapping,
} from './organization/Settings/Permissions/permissionsLogic'
import { rolesLogic } from './organization/Settings/Permissions/Roles/rolesLogic'
} from './settings/organization/Permissions/permissionsLogic'
import { rolesLogic } from './settings/organization/Permissions/Roles/rolesLogic'
import { urls } from './urls'

interface ResourcePermissionProps {
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/scenes/appScenes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const appScenes: Record<Scene, () => any> = {
[Scene.DataWarehouseExternal]: () => import('./data-warehouse/external/DataWarehouseExternalScene'),
[Scene.DataWarehouseSavedQueries]: () => import('./data-warehouse/saved_queries/DataWarehouseSavedQueriesScene'),
[Scene.DataWarehouseSettings]: () => import('./data-warehouse/settings/DataWarehouseSettingsScene'),
[Scene.OrganizationSettings]: () => import('./organization/Settings'),
[Scene.OrganizationSettings]: () => import('./settings/organization'),
[Scene.OrganizationCreateFirst]: () => import('./organization/Create'),
[Scene.OrganizationCreationConfirm]: () => import('./organization/ConfirmOrganization/ConfirmOrganization'),
[Scene.ProjectHomepage]: () => import('./project-homepage/ProjectHomepage'),
Expand All @@ -57,7 +57,7 @@ export const appScenes: Record<Scene, () => any> = {
[Scene.Site]: () => import('./sites/Site'),
[Scene.AsyncMigrations]: () => import('./instance/AsyncMigrations/AsyncMigrations'),
[Scene.DeadLetterQueue]: () => import('./instance/DeadLetterQueue/DeadLetterQueue'),
[Scene.MySettings]: () => import('./me/Settings'),
[Scene.MySettings]: () => import('./me/settings'),
[Scene.Annotations]: () => import('./annotations/Annotations'),
[Scene.PreflightCheck]: () => import('./PreflightCheck/PreflightCheck'),
[Scene.Signup]: () => import('./authentication/signup/SignupContainer'),
Expand All @@ -83,4 +83,5 @@ export const appScenes: Record<Scene, () => any> = {
[Scene.Canvas]: () => import('./notebooks/NotebookCanvasScene'),
[Scene.Products]: () => import('./products/Products'),
[Scene.Onboarding]: () => import('./onboarding/Onboarding'),
[Scene.Settings]: () => import('./settings/SettingsScene'),
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { LemonDivider } from 'lib/lemon-ui/LemonDivider'
import { LemonRow } from 'lib/lemon-ui/LemonRow'
import { DASHBOARD_CANNOT_EDIT_MESSAGE } from '../DashboardHeader'
import { LemonInput, LemonSelect } from '@posthog/lemon-ui'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { LemonMarkdown } from 'lib/lemon-ui/LemonMarkdown'

export function DashboardsTableContainer(): JSX.Element {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { actions, afterMount, connect, kea, key, path, props, reducers, selector
import { loaders } from 'kea-loaders'
import api from 'lib/api'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { rolesLogic } from 'scenes/organization/Settings/Permissions/Roles/rolesLogic'
import { rolesLogic } from 'scenes/settings/organization/Permissions/Roles/rolesLogic'
import { AccessLevel, FeatureFlagAssociatedRoleType, Resource, RoleType } from '~/types'

import type { featureFlagPermissionsLogicType } from './featureFlagPermissionsLogicType'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { LemonButton } from '@posthog/lemon-ui'
import { useActions } from 'kea'
import { IconArrowRight } from 'lib/lemon-ui/icons'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'

export function IngestionInviteMembersButton(): JSX.Element {
const { showInviteModal } = useActions(inviteLogic)
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/ingestion/IngestionWizard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import { GeneratingDemoDataPanel } from './panels/GeneratingDemoDataPanel'
import { ThirdPartyPanel } from './panels/ThirdPartyPanel'
import { BillingPanel } from './panels/BillingPanel'
import { Sidebar } from './Sidebar'
import { InviteModal } from 'scenes/organization/Settings/InviteModal'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { InviteModal } from 'scenes/settings/organization/InviteModal'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { Logo } from '~/toolbar/assets/Logo'
import { SitePopover } from '~/layout/navigation/TopBar/SitePopover'
import { HelpButton } from 'lib/components/HelpButton/HelpButton'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/ingestion/ingestionLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { windowValues } from 'kea-window-values'
import { subscriptions } from 'kea-subscriptions'
import { TeamType } from '~/types'
import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import api from 'lib/api'
import { loaders } from 'kea-loaders'
import type { ingestionLogicType } from './ingestionLogicType'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/ingestion/panels/InviteTeamPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { LemonButton } from 'lib/lemon-ui/LemonButton'
import './Panels.scss'
import { LemonDivider } from 'lib/lemon-ui/LemonDivider'
import { IconChevronRight } from 'lib/lemon-ui/icons'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { DemoProjectButton } from './PanelComponents'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ExclamationCircleOutlined } from '@ant-design/icons'
import { personalAPIKeysLogic } from './personalAPIKeysLogic'
import { PersonalAPIKeyType } from '~/types'
import { humanFriendlyDetailedTime } from 'lib/utils'
import { CopyToClipboardInline } from '../CopyToClipboard'
import { CopyToClipboardInline } from '../../../lib/components/CopyToClipboard'
import { ColumnsType } from 'antd/lib/table'
import { LemonButton } from 'lib/lemon-ui/LemonButton'
import { LemonInput, LemonModal, Link } from '@posthog/lemon-ui'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { LemonButton, LemonModal } from '@posthog/lemon-ui'
import { IconCheckmark, IconWarning } from 'lib/lemon-ui/icons'
import { useState } from 'react'
import { Setup2FA } from 'scenes/authentication/Setup2FA'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'

export function TwoFactorAuthentication(): JSX.Element {
const { user } = useValues(userLogic)
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/me/Settings/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useAnchor } from 'lib/hooks/useAnchor'
import { router } from 'kea-router'
import { UpdateEmailPreferences } from './UpdateEmailPreferences'
import { ChangePassword } from './ChangePassword'
import { PersonalAPIKeys } from 'lib/components/PersonalAPIKeys'
import { PersonalAPIKeys } from 'scenes/settings/user/PersonalAPIKeys'
import { OptOutCapture } from './OptOutCapture'
import { PageHeader } from 'lib/components/PageHeader'
import { SceneExport } from 'scenes/sceneTypes'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { useEffect } from 'react'
import { LemonBanner } from 'lib/lemon-ui/LemonBanner'
import { LemonMenu } from 'lib/lemon-ui/LemonMenu'
import { IconDelete, IconEllipsis } from 'lib/lemon-ui/icons'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { ContainsTypeFilters } from 'scenes/notebooks/NotebooksTable/ContainsTypeFilter'
import { DEFAULT_FILTERS, notebooksTableLogic } from 'scenes/notebooks/NotebooksTable/notebooksTableLogic'
import { notebookPanelLogic } from '../NotebookPanel/notebookPanelLogic'
Expand Down
Empty file.
2 changes: 1 addition & 1 deletion frontend/src/scenes/project-homepage/ProjectHomepage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useActions, useValues } from 'kea'
import { teamLogic } from 'scenes/teamLogic'
import { Scene, SceneExport } from 'scenes/sceneTypes'
import { DashboardPlacement } from '~/types'
import { inviteLogic } from 'scenes/organization/Settings/inviteLogic'
import { inviteLogic } from 'scenes/settings/organization/inviteLogic'
import { LemonDivider } from 'lib/lemon-ui/LemonDivider'
import { IconCottage } from 'lib/lemon-ui/icons'
import { projectHomepageLogic } from 'scenes/project-homepage/projectHomepageLogic'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/project/Settings/teamMembersLogic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
UserType,
} from '~/types'
import type { teamMembersLogicType } from './teamMembersLogicType'
import { membersLogic } from '../../organization/Settings/membersLogic'
import { membersLogic } from '../../settings/organization/membersLogic'
import { membershipLevelToName } from 'lib/utils/permissioning'
import { userLogic } from '../../userLogic'
import { teamLogic } from '../../teamLogic'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { INSIGHT_TYPE_OPTIONS } from 'scenes/saved-insights/SavedInsights'
import { useActions, useValues } from 'kea'
import { dashboardsModel } from '~/models/dashboardsModel'
import { savedInsightsLogic } from 'scenes/saved-insights/savedInsightsLogic'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { LemonInput } from 'lib/lemon-ui/LemonInput/LemonInput'

export function SavedInsightsFilters(): JSX.Element {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/sceneTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export enum Scene {
Canvas = 'Canvas',
Products = 'Products',
Onboarding = 'Onboarding',
Settings = 'Settings',
}

export type SceneProps = Record<string, any>
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/scenes/scenes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,10 @@ export const sceneConfigurations: Partial<Record<Scene, SceneConfig>> = {
name: 'Canvas',
layout: 'app-raw',
},
[Scene.Settings]: {
projectBased: true,
name: 'Settings',
},
}

const preserveParams = (url: string) => (_params: Params, searchParams: Params, hashParams: Params) => {
Expand Down Expand Up @@ -514,4 +518,5 @@ export const routes: Record<string, Scene> = {
[urls.notebook(':shortId')]: Scene.Notebook,
[urls.notebooks()]: Scene.Notebooks,
[urls.canvas()]: Scene.Canvas,
[urls.settings()]: Scene.Settings,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { LemonTableColumn, LemonTableColumns } from 'lib/lemon-ui/LemonTable'
import { urls } from 'scenes/urls'
import { createdByColumn } from 'lib/lemon-ui/LemonTable/columnUtils'
import { DateFilter } from 'lib/components/DateFilter/DateFilter'
import { membersLogic } from 'scenes/organization/Settings/membersLogic'
import { membersLogic } from 'scenes/settings/organization/membersLogic'
import { TZLabel } from '@posthog/apps-common'
import { SavedSessionRecordingPlaylistsEmptyState } from 'scenes/session-recordings/saved-playlists/SavedSessionRecordingPlaylistsEmptyState'
import clsx from 'clsx'
Expand Down
Loading
Loading