-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flags): allow overrides for disabled flags #18408
Closed
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7a838f9
fix(flags): allow overrides for disabled flags
liyiy 7b826b5
use get_all_feature_flags
liyiy a01025c
Merge branch 'master' into flags-toolbar
liyiy 867d41a
Update UI snapshots for `chromium` (2)
github-actions[bot] 3dd59c9
Update UI snapshots for `chromium` (2)
github-actions[bot] c0769d9
Update UI snapshots for `chromium` (1)
github-actions[bot] bb80c53
Update UI snapshots for `chromium` (2)
github-actions[bot] 77dfc9d
Update UI snapshots for `chromium` (1)
github-actions[bot] 7e07a6c
Update UI snapshots for `chromium` (2)
github-actions[bot] 18f39b6
Update UI snapshots for `chromium` (1)
github-actions[bot] a14643b
Update UI snapshots for `chromium` (2)
github-actions[bot] 7e64390
Update UI snapshots for `chromium` (1)
github-actions[bot] fad68a0
Update UI snapshots for `webkit` (2)
github-actions[bot] 4faa641
Update UI snapshots for `chromium` (2)
github-actions[bot] 1d4586a
Update UI snapshots for `webkit` (2)
github-actions[bot] 9981619
Update UI snapshots for `chromium` (2)
github-actions[bot] 48759a4
Update UI snapshots for `chromium` (2)
github-actions[bot] bcfa7b4
Update UI snapshots for `chromium` (2)
github-actions[bot] 8b5a9e0
Update UI snapshots for `chromium` (1)
github-actions[bot] 5589d1a
Update UI snapshots for `chromium` (1)
github-actions[bot] d3857e1
Update UI snapshots for `chromium` (2)
github-actions[bot] 757fda1
Update UI snapshots for `chromium` (2)
github-actions[bot] ef3c35c
Update UI snapshots for `webkit` (2)
github-actions[bot] 0083c75
Update UI snapshots for `chromium` (1)
github-actions[bot] e105210
Update UI snapshots for `webkit` (2)
github-actions[bot] fb5bd8a
Update UI snapshots for `chromium` (2)
github-actions[bot] 40a1213
Update query snapshots
github-actions[bot] 16fe60c
Update UI snapshots for `chromium` (2)
github-actions[bot] 1f82e67
Update query snapshots
github-actions[bot] 6b399e1
Update UI snapshots for `chromium` (2)
github-actions[bot] bad0662
Update query snapshots
github-actions[bot] 4099504
Merge branch 'master' into flags-toolbar
liyiy 0b2acf3
Merge branch 'flags-toolbar' of https://github.com/PostHog/posthog in…
liyiy a7372a7
Update UI snapshots for `chromium` (2)
github-actions[bot] e0d5043
Update UI snapshots for `chromium` (1)
github-actions[bot] 15fab91
Update query snapshots
github-actions[bot] 9198fa7
Update UI snapshots for `chromium` (2)
github-actions[bot] 1c7ce8f
Update UI snapshots for `chromium` (1)
github-actions[bot] 10cb18a
Update UI snapshots for `chromium` (2)
github-actions[bot] ae8b36d
Update UI snapshots for `chromium` (2)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+10.7 KB
(120%)
frontend/__snapshots__/scenes-app-insights--stickiness-edit--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.81 KB
(98%)
frontend/__snapshots__/scenes-app-insights--trends-line-edit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.77 KB
(92%)
frontend/__snapshots__/scenes-app-notebooks--recordings-playlist.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
frontend/__snapshots__/scenes-other-billing-v2--billing-v-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a follow up, you should also replace L479 with
get_all_feature_flags
, because right now this gives incorrect responses for some flags because it's missing logic for hash key overrides, for example.