Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove antd Space component #18396

Merged
merged 5 commits into from
Nov 6, 2023
Merged

chore: remove antd Space component #18396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07a3bde
chore: remove antd Space component
daibhin Nov 3, 2023
920604f
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 3, 2023
0111fa6
Merge branch 'master' into dn-chore/remove-antd-space
daibhin Nov 6, 2023
85e6dff
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 6, 2023
00fdc49
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ module.exports = {
element: 'Col',
message: 'use flex utility classes instead - most of the time can simply be a plain <div>',
},
{
element: 'Space',
message: 'use flex or space utility classes instead',
},
{
element: 'Divider',
message: 'use <LemonDivider> instead',
Expand Down Expand Up @@ -161,6 +157,10 @@ module.exports = {
element: 'Tabs',
message: 'use <LemonTabs> instead',
},
{
element: 'Space',
message: 'use flex or space utility classes instead',
},
{
element: 'Spin',
message: 'use Spinner instead',
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/lib/components/InsightLabel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Space, Tag } from 'antd'
import { Tag } from 'antd'
import { ActionFilter, BreakdownKeyType } from '~/types'
import { PropertyKeyInfo } from 'lib/components/PropertyKeyInfo'
import { capitalizeFirstLetter, hexToRGBA, midEllipsis } from 'lib/utils'
Expand Down Expand Up @@ -168,7 +168,7 @@ export function InsightLabel({
)}

{pillValues.length > 0 && (
<Space direction={'horizontal'} wrap={true}>
<div className="flex flex-wrap gap-1">
{pillValues.map((pill) => (
<Tooltip title={pill} key={pill}>
<Tag className="tag-pill" closable={false}>
Expand All @@ -179,7 +179,7 @@ export function InsightLabel({
</Tag>
</Tooltip>
))}
</Space>
</div>
)}
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/scenes/dashboard/DashboardReloadAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Radio, Space, RadioChangeEvent } from 'antd'
import { Radio, RadioChangeEvent } from 'antd'
import { dashboardLogic, DASHBOARD_MIN_REFRESH_INTERVAL_MINUTES } from 'scenes/dashboard/dashboardLogic'
import { useActions, useValues } from 'kea'
import { humanFriendlyDuration } from 'lib/utils'
Expand Down Expand Up @@ -82,7 +82,7 @@ export function DashboardReloadAction(): JSX.Element {
value={autoRefresh.interval}
style={{ width: '100%' }}
>
<Space direction="vertical" style={{ width: '100%' }}>
<div className="flex flex-col gap-2">
{intervalOptions.map(({ label, value }) => (
<Radio
key={value}
Expand All @@ -93,7 +93,7 @@ export function DashboardReloadAction(): JSX.Element {
{label}
</Radio>
))}
</Space>
</div>
</Radio.Group>
</div>
</div>
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/scenes/instance/AsyncMigrations/AsyncMigrations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useEffect } from 'react'
import { PageHeader } from 'lib/components/PageHeader'
import { SceneExport } from 'scenes/sceneTypes'
import { Button, Progress, Space } from 'antd'
import { Button, Progress } from 'antd'
import { useActions, useValues } from 'kea'
import { PlayCircleOutlined } from '@ant-design/icons'
import {
Expand Down Expand Up @@ -309,7 +309,6 @@ export function AsyncMigrations(): JSX.Element {
Refresh
</LemonButton>
</div>
<Space />
<LemonTable
pagination={{ pageSize: 10 }}
loading={asyncMigrationsLoading}
Expand Down
42 changes: 21 additions & 21 deletions frontend/src/scenes/plugins/edit/PluginDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { useEffect, useState } from 'react'
import { useActions, useValues } from 'kea'
import { pluginsLogic } from 'scenes/plugins/pluginsLogic'
import { Button, Form, Space, Switch } from 'antd'
import { CodeOutlined, LockFilled } from '@ant-design/icons'
import { Form, Switch } from 'antd'
import { LockFilled } from '@ant-design/icons'
import { userLogic } from 'scenes/userLogic'
import { PluginImage } from 'scenes/plugins/plugin/PluginImage'
import { Drawer } from 'lib/components/Drawer'
Expand All @@ -18,7 +18,8 @@ import { PluginJobOptions } from './interface-jobs/PluginJobOptions'
import { MOCK_NODE_PROCESS } from 'lib/constants'
import { LemonMarkdown } from 'lib/lemon-ui/LemonMarkdown'
import { PluginTags } from '../tabs/apps/components'
import { LemonTag, Link } from '@posthog/lemon-ui'
import { LemonButton, LemonTag, Link } from '@posthog/lemon-ui'
import { IconCode } from '@posthog/icons'

window.process = MOCK_NODE_PROCESS

Expand Down Expand Up @@ -136,20 +137,19 @@ export function PluginDrawer(): JSX.Element {
title={editingPlugin?.name}
data-attr="plugin-drawer"
footer={
<div className="flex">
<Space>
<Button onClick={() => editPlugin(null)} data-attr="plugin-drawer-cancel">
Cancel
</Button>
<Button
type="primary"
loading={loading}
onClick={form.submit}
data-attr="plugin-drawer-save"
>
Save
</Button>
</Space>
<div className="flex space-x-2">
<LemonButton size="small" onClick={() => editPlugin(null)} data-attr="plugin-drawer-cancel">
Cancel
</LemonButton>
<LemonButton
size="small"
type="primary"
loading={loading}
onClick={form.submit}
data-attr="plugin-drawer-save"
>
Save
</LemonButton>
</div>
}
>
Expand Down Expand Up @@ -184,14 +184,14 @@ export function PluginDrawer(): JSX.Element {

{editingPlugin.plugin_type === 'source' && canGloballyManagePlugins(user?.organization) ? (
<div>
<Button
type={editingSource ? 'default' : 'primary'}
icon={<CodeOutlined />}
<LemonButton
status={editingSource ? 'muted' : 'primary'}
icon={<IconCode />}
onClick={() => setEditingSource(!editingSource)}
data-attr="plugin-edit-source"
>
Edit source
</Button>
</LemonButton>
</div>
) : null}

Expand Down
Loading