fix(webhooks): Always check for unsafe urls #18360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism is now only disabled in local dev.
tiina303
approved these changes
Nov 3, 2023
Twixes
approved these changes
Nov 3, 2023
tomasfarias
pushed a commit
that referenced
this pull request
Nov 6, 2023
* fix(webhooks): Always check for unsafe urls * Roll out the hostname guard fully The mechanism is now only disabled in local dev. * Update hooks.test.ts * Disable URL check in functional tests --------- Co-authored-by: Michael Matloka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were only checking for unsafe urls on cloud, but we should probably check self hosted too
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?