feat(flags): Add relative date operators #18349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajmajerik
reviewed
Nov 3, 2023
posthog/queries/base.py
Outdated
| parsed_dt = datetime.datetime.now(tz=ZoneInfo("UTC")) | ||
| if match: | ||
| number = int(match.group("number")) | ||
| type = match.group("type") |
There was a problem hiding this comment.
This will overshadow the built-in type() function, maybe consider a different name?
jurajmajerik
approved these changes
Nov 3, 2023
liyiy
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #17392 - part 1. UI to follow after SDK updates.
Add relative date operators, which allow you to query date/datetime properties with operators like "24h" for within last 24 hours, and "3d" for within last 3 days for example.
Also supports relative date before & after, i.e. within or outside the relative range.
The parsing is similar to what we do for insights, to keep things closely related, but not reusing the same because it has a lot more logic around team timezones and other stuff we don't need. Also less risky to keep it separate, as we wouldn't want updates there to break flags, or vice versa, since these end up going to separate systems: Flags go to postgres, insights go to clickhouse.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Need to update tests, resolve TODOs