feat(feature flags): add plain UI for Feature Flag copy #18324
Conversation
jurajmajerik
requested review from
neilkakkar,
liyiy and
smallbrownbike
and removed request for
smallbrownbike
| columns={columns} | ||
| emptyState="This feature flag is not being used in any other project." | ||
| /> | ||
| <CopyFeatureFlagModal /> |
There was a problem hiding this comment.
if this is on it's own page, a modal doesn't make too much sense to me, can we inline it instead?
There was a problem hiding this comment.
Right, that makes a lot of sense :)
| </div> | ||
| <Field name="Project" label="Project" className="flex-1"> | ||
| <LemonSelect | ||
| value={currentOrganization?.teams?.[0].id} |
There was a problem hiding this comment.
is this the current team?
There was a problem hiding this comment.
yes, this is just a placeholder for now. The whole tab will be hidden for anyone having only 1 team and here, some other team than the current team can be pre-selected (or none)
| > | ||
| <div className="max-w-120"> | ||
| <Form | ||
| logic={featureFlagLogic} |
There was a problem hiding this comment.
depending on whether there's a bindlogic before the tabs or not, this might require the props to be passed in 👀
Co-authored-by: Neil Kakkar <[email protected]>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| @@ -16,6 +16,7 @@ export enum FeatureFlagsTab { | |||
| Analysis = 'analysis', | |||
| USAGE = 'usage', | |||
| PERMISSIONS = 'permissions', | |||
| PROJECTS = 'projects', | |||
There was a problem hiding this comment.
We can change this later on but I think 'projects' makes me think of feature flag projects (??) when the concept we want more is like... feature flag environments xD or like... feature flag syncs...
There was a problem hiding this comment.
idk, non blocking right now, but it'll be confusing later on IMO
There was a problem hiding this comment.
I agree, on the other hand users already use projects as environments, so a discrepancy in naming might be confusing here. But happy to discuss it, we can always adjust.
|
Thanks for the review @liyiy, in the meantime I moved the form out of the modal - no big changes otherwise, so will merge now to keep moving :) 
|
…g/posthog into fix/feature-flags-filters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
feature flag: multi-project-feature-flags (rolled out to #team-feature-success only)
Changes
Added plain UI for copying a feature flag from one project to another.
Added a new Projects tab within the Feature Flag view. Put everything there as it feels cleaner / don't want to clutter the Overview. We can adjust as we go.
How did you test this code?
👀