chore: renamed non-inclusive language

.github/workflows/inclusive.yml

@@ -0,0 +1,15 @@
+name: Inclusive Language Linter
+
+on: [pull_request]
+
+jobs:
+    lint:
+        name: Linting language
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v2
+            - uses: get-woke/woke-action-reviewdog@v0
+              with:
+                  github-token: ${{ secrets.GITHUB_TOKEN }}
+                  reporter: github-pr-review
+                  level: warning

.wokeignore

@@ -0,0 +1,12 @@
+.wokeignore
+posthog/management/sql/0050_event_partitions.sql
+posthog/migrations/0001_initial_squashed_0284_improved_caching_state_idx.py
+posthog/migrations/0160_organization_domain_whitelist.py
+posthog/migrations/0161_property_defs_search.py
+posthog/migrations/0223_organizationdomain.py
+*.ambr
+frontend/src/scenes/plugins/source/types/packages.json
+# External lib settings
+posthog/settings/web.py
+# External lib settings 
+ee/settings.py

ee/clickhouse/materialized_columns/test/test_analyze.py

@@ -8,7 +8,7 @@
 class TestMaterializedColumnsAnalyze(ClickhouseTestMixin, BaseTest):
     def setUp(self):
         super().setUp()
-        self.DUMMY_QUERIES = [
+        self.SAMPLE_QUERIES = [
             (
                 f"""
                 SELECT JSONExtractString(e.properties, 'event_prop')
@@ -71,10 +71,10 @@ def setUp(self):
 
     def test_query_class(self):
         with self.settings(MATERIALIZE_COLUMNS_MINIMUM_QUERY_TIME=3000):
-            event_query = Query(*self.DUMMY_QUERIES[0])
-            person_query = Query(*self.DUMMY_QUERIES[1])
-            person_on_events_query = Query(*self.DUMMY_QUERIES[2])
-            group_on_events_query = Query(*self.DUMMY_QUERIES[3])
+            event_query = Query(*self.SAMPLE_QUERIES[0])
+            person_query = Query(*self.SAMPLE_QUERIES[1])
+            person_on_events_query = Query(*self.SAMPLE_QUERIES[2])
+            group_on_events_query = Query(*self.SAMPLE_QUERIES[3])
 
             self.assertTrue(event_query.is_valid)
             self.assertTrue(person_query.is_valid)

frontend/src/initKea.ts

@@ -13,7 +13,7 @@ import { formsPlugin } from 'kea-forms'
 Actions for which we don't want to show error alerts,
 mostly to avoid user confusion.
 */
-const ERROR_FILTER_WHITELIST = [
+const ERROR_FILTER_ALLOW_LIST = [
     'loadPreflight', // Gracefully handled if it fails
     'loadUser', // App won't load (unless loading from shared dashboards)
     'loadFunnels', // Special error handling on insights
@@ -79,7 +79,7 @@ export function initKea({ routerHistory, routerLocation, beforePlugins }: InitKe
             onFailure({ error, reducerKey, actionKey }: { error: any; reducerKey: string; actionKey: string }) {
                 // Toast if it's a fetch error or a specific API update error
                 if (
-                    !ERROR_FILTER_WHITELIST.includes(actionKey) &&
+                    !ERROR_FILTER_ALLOW_LIST.includes(actionKey) &&
                     (error?.message === 'Failed to fetch' || // Likely CORS headers errors (i.e. request failing without reaching Django)
                         (error?.status !== undefined && ![200, 201, 204].includes(error.status)))
                 ) {

frontend/src/layout/navigation/ProjectNotice.tsx

@@ -37,7 +37,7 @@ export function ProjectNotice(): JSX.Element | null {
         demo_project: {
             message: (
                 <>
-                    This is a demo project with dummy data.
+                    This is a demo project with sample data.
                     {altTeamForIngestion && (
                         <>
                             {' '}

frontend/src/scenes/instance/SystemStatus/systemStatusLogic.ts

@@ -19,7 +19,7 @@ export enum ConfigMode {
 export type InstanceStatusTabName = 'overview' | 'metrics' | 'settings' | 'staff_users' | 'kafka_inspector'
 
 /**
- * We whitelist the specific instance settings that can be edited via the /instance/status page.
+ * We allow the specific instance settings that can be edited via the /instance/status page.
  * Even if some settings are editable in the frontend according to the API, we may don't want to expose them here.
  * For example: async migrations settings are handled in their own page.
  */

frontend/src/scenes/organization/Settings/VerifiedDomains/VerifiedDomains.tsx

@@ -28,7 +28,6 @@ export function VerifiedDomains(): JSX.Element {
         <>
             <div className="flex items-center">
                 <div style={{ flexGrow: 1 }}>
-                    <div id="domain-whitelist" /> {/** For backwards link compatibility. Remove after 2022-06-01. */}
                     <h2 id="authentication-domains" className="subtitle">
                         Authentication domains
                     </h2>

frontend/src/scenes/project/Settings/DataAttributes.tsx

@@ -33,8 +33,8 @@ export function DataAttributes(): JSX.Element {
             <p>
                 For example, when creating an action on your CTA button, the best selector could be something like:{' '}
                 <code>div &gt; form &gt; button:nth-child(2)</code>. However all buttons in your app have a{' '}
-                <code>data-custom-id</code> attribute. If you whitelist it here, the selector for your button will
-                instead be <code>button[data-custom-id='cta-button']</code>.
+                <code>data-custom-id</code> attribute. If you allow it here, the selector for your button will instead
+                be <code>button[data-custom-id='cta-button']</code>.
             </p>
             <div className="space-y-4 max-w-160">
                 <LemonSelectMultiple

frontend/src/scenes/project/Settings/WebhookIntegration.tsx

@@ -21,8 +21,8 @@ export function WebhookIntegration(): JSX.Element {
         }
     }, [currentTeam])
 
-    const webhooks_blacklisted = featureFlags[FEATURE_FLAGS.WEBHOOKS_DENYLIST]
-    if (webhooks_blacklisted) {
+    const webhooks_disallowed = featureFlags[FEATURE_FLAGS.WEBHOOKS_DENYLIST]
+    if (webhooks_disallowed) {
         return (
             <div>
                 <p>

plugin-server/src/main/ingestion-queues/session-recording/services/offset-high-water-marker.ts

@@ -73,7 +73,7 @@ export class OffsetHighWaterMarker {
         const watermarks = await this.getWaterMarks(tp)
 
         if (offset <= (watermarks[id] ?? -1)) {
-            // SANITY CHECK: We don't want to add an offset that is less than or equal to the current offset
+            // COHERENCE CHECK: We don't want to add an offset that is less than or equal to the current offset
             return
         }
 

plugin-server/src/worker/ingestion/event-pipeline/runner.ts

@@ -71,7 +71,7 @@ export class EventPipelineRunner {
         this.originalEvent = event
     }
 
-    isEventBlacklisted(event: PipelineEvent): boolean {
+    isEventDisallowed(event: PipelineEvent): boolean {
         // During incidents we can use the the env DROP_EVENTS_BY_TOKEN_DISTINCT_ID
         // to drop events here before processing them which would allow us to catch up
         const key = event.token || event.team_id?.toString()
@@ -87,14 +87,14 @@ export class EventPipelineRunner {
         this.hub.statsd?.increment('kafka_queue.event_pipeline.start', { pipeline: 'event' })
 
         try {
-            if (this.isEventBlacklisted(event)) {
+            if (this.isEventDisallowed(event)) {
                 eventDroppedCounter
                     .labels({
                         event_type: 'analytics',
-                        drop_cause: 'blacklisted',
+                        drop_cause: 'disallowed',
                     })
                     .inc()
-                return this.registerLastStep('eventBlacklistingStep', null, [event])
+                return this.registerLastStep('eventDisallowedStep', null, [event])
             }
             let result: EventPipelineResult
             const eventWithTeam = await this.runStep(populateTeamDataStep, [this, event], event.team_id || -1)
@@ -204,7 +204,7 @@ export class EventPipelineRunner {
             // for a reason that we control and that is transient.
             return true
         }
-        // TODO: Blacklist via env of errors we're going to put into DLQ instead of taking Kafka lag
+        // TODO: Disalow via env of errors we're going to put into DLQ instead of taking Kafka lag
         return false
     }
 

plugin-server/src/worker/vm/extensions/google.ts

@@ -1,16 +1,16 @@
 import * as BigQuery from '@google-cloud/bigquery'
 import * as PubSub from '@google-cloud/pubsub'
 
-type DummyCloud = {
+type MockedCloud = {
     bigquery: typeof BigQuery
     pubsub: typeof PubSub
 }
 
-type DummyGoogle = {
-    cloud: DummyCloud
+type MockedGoogle = {
+    cloud: MockedCloud
 }
 
-export function createGoogle(): DummyGoogle {
+export function createGoogle(): MockedGoogle {
     return {
         cloud: {
             bigquery: BigQuery,

plugin-server/src/worker/vm/extensions/posthog.ts

@@ -17,7 +17,7 @@ interface InternalData {
     uuid: string
 }
 
-export interface DummyPostHog {
+export interface MockedPostHog {
     capture(event: string, properties?: Record<string, any>): Promise<void>
     api: ApiExtension
 }
@@ -47,7 +47,7 @@ async function queueEvent(hub: Hub, pluginConfig: PluginConfig, data: InternalDa
     })
 }
 
-export function createPosthog(hub: Hub, pluginConfig: PluginConfig): DummyPostHog {
+export function createPosthog(hub: Hub, pluginConfig: PluginConfig): MockedPostHog {
     const distinctId = pluginConfig.plugin?.name || `plugin-id-${pluginConfig.plugin_id}`
 
     return {

plugin-server/src/worker/vm/lazy.ts

@@ -212,8 +212,8 @@ export class LazyPluginVM {
                 const team = await this.hub.teamManager.fetchTeam(this.pluginConfig.team_id)
                 // There's a single team with replication for the same api key from US to EU
                 // otherwise we're just checking that token differs to better safeguard against forwarding
-                const isWhitelisted = team?.uuid == '017955d2-b09f-0000-ec00-2116c7e8a605' && host == 'eu.posthog.com'
-                if (!isWhitelisted && team?.api_token.trim() == apiKey.trim()) {
+                const isAllowed = team?.uuid == '017955d2-b09f-0000-ec00-2116c7e8a605' && host == 'eu.posthog.com'
+                if (!isAllowed && team?.api_token.trim() == apiKey.trim()) {
                     throw Error('Self replication is not allowed')
                 }
                 // Only default org can use higher than 1x replication

plugin-server/tests/e2e.timeout.test.ts

@@ -3,7 +3,7 @@ import { startPluginsServer } from '../src/main/pluginsServer'
 import { Hub, LogLevel, PluginsServerConfig } from '../src/types'
 import { delay, UUIDT } from '../src/utils/utils'
 import { makePiscina } from '../src/worker/piscina'
-import { createPosthog, DummyPostHog } from '../src/worker/vm/extensions/posthog'
+import { createPosthog, MockedPostHog } from '../src/worker/vm/extensions/posthog'
 import { delayUntilEventIngested, resetTestDatabaseClickhouse } from './helpers/clickhouse'
 import { resetKafka } from './helpers/kafka'
 import { pluginConfig39 } from './helpers/plugins'
@@ -21,7 +21,7 @@ const extraServerConfig: Partial<PluginsServerConfig> = {
 describe('e2e ingestion timeout', () => {
     let hub: Hub
     let stopServer: () => Promise<void>
-    let posthog: DummyPostHog
+    let posthog: MockedPostHog
 
     beforeAll(async () => {
         await resetKafka(extraServerConfig)

plugin-server/tests/main/ingestion-queues/kafka-queue.test.ts

@@ -7,7 +7,7 @@ import { LogLevel, PluginsServerConfig } from '../../../src/types'
 import { Hub } from '../../../src/types'
 import { UUIDT } from '../../../src/utils/utils'
 import { makePiscina } from '../../../src/worker/piscina'
-import { createPosthog, DummyPostHog } from '../../../src/worker/vm/extensions/posthog'
+import { createPosthog, MockedPostHog } from '../../../src/worker/vm/extensions/posthog'
 import { writeToFile } from '../../../src/worker/vm/extensions/test-utils'
 import { delayUntilEventIngested, resetTestDatabaseClickhouse } from '../../helpers/clickhouse'
 import { resetKafka } from '../../helpers/kafka'
@@ -31,7 +31,7 @@ const extraServerConfig: Partial<PluginsServerConfig> = {
 describe.skip('IngestionConsumer', () => {
     let hub: Hub
     let stopServer: () => Promise<void>
-    let posthog: DummyPostHog
+    let posthog: MockedPostHog
     let pluginServer: ServerInstance
 
     beforeAll(async () => {

plugin-server/tests/main/ingestion-queues/session-recording/session-recordings-consumer.test.ts

@@ -639,7 +639,7 @@ describe('ingester', () => {
             await ingester.handleEachBatch(partitionMsgs1)
         }
 
-        // NOTE: This test is a sanity check for the follow up test. It demonstrates what happens if we shutdown in the wrong order
+        // NOTE: This test is a coherence check for the follow up test. It demonstrates what happens if we shutdown in the wrong order
         // It doesn't reliably work though as the onRevoke is called via the kafka lib ending up with dangling promises so rather it is here as a reminder
         // demonstation for when we need it
         it.skip('shuts down with error if redis forcefully shutdown', async () => {

plugin-server/tests/worker/ingestion/event-pipeline/runner.test.ts

@@ -121,7 +121,7 @@ describe('EventPipelineRunner', () => {
             expect(runner.stepsWithArgs).toMatchSnapshot()
         })
 
-        it('drops blacklisted events', async () => {
+        it('drops disallowed events', async () => {
             const event = {
                 ...pipelineEvent,
                 token: 'drop_token',
@@ -131,7 +131,7 @@ describe('EventPipelineRunner', () => {
             expect(runner.steps).toEqual([])
         })
 
-        it('does not drop blacklisted token mismatching distinct_id events', async () => {
+        it('does not drop disallowed token mismatching distinct_id events', async () => {
             const event = {
                 ...pipelineEvent,
                 token: 'drop_token',
@@ -146,7 +146,7 @@ describe('EventPipelineRunner', () => {
             ])
         })
 
-        it('drops blacklisted events by *', async () => {
+        it('drops disallowed events by *', async () => {
             const event = {
                 ...pipelineEvent,
                 token: 'drop_token_all',

posthog/api/signup.py

@@ -402,7 +402,7 @@ def process_social_invite_signup(strategy: DjangoStrategy, invite_id: str, email
 def process_social_domain_jit_provisioning_signup(
     email: str, full_name: str, user: Optional[User] = None
 ) -> Optional[User]:
-    # Check if the user is on a whitelisted domain
+    # Check if the user is on a allowed domain
     domain = email.split("@")[-1]
     try:
         logger.info(f"process_social_domain_jit_provisioning_signup", domain=domain)

posthog/api/survey.py

@@ -101,11 +101,11 @@ def validate_appearance(self, value):
 
         thank_you_message = value.get("thankYouMessageHeader")
         if thank_you_message and nh3.is_html(thank_you_message):
-            value["thankYouMessageHeader"] = nh3_clean_with_whitelist(thank_you_message)
+            value["thankYouMessageHeader"] = nh3_clean_with_allow_list(thank_you_message)
 
         thank_you_description = value.get("thankYouMessageDescription")
         if thank_you_description and nh3.is_html(thank_you_description):
-            value["thankYouMessageDescription"] = nh3_clean_with_whitelist(thank_you_description)
+            value["thankYouMessageDescription"] = nh3_clean_with_allow_list(thank_you_description)
 
         return value
 
@@ -131,9 +131,9 @@ def validate_questions(self, value):
 
             description = raw_question.get("description")
             if nh3.is_html(question_text):
-                cleaned_question["question"] = nh3_clean_with_whitelist(question_text)
+                cleaned_question["question"] = nh3_clean_with_allow_list(question_text)
             if description and nh3.is_html(description):
-                cleaned_question["description"] = nh3_clean_with_whitelist(description)
+                cleaned_question["description"] = nh3_clean_with_allow_list(description)
 
             cleaned_questions.append(cleaned_question)
 
@@ -347,7 +347,7 @@ def surveys(request: Request):
     return cors_response(request, JsonResponse({"surveys": surveys}))
 
 
-def nh3_clean_with_whitelist(to_clean: str):
+def nh3_clean_with_allow_list(to_clean: str):
     return nh3.clean(
         to_clean,
         link_rel="noopener",
@@ -431,7 +431,7 @@ def nh3_clean_with_whitelist(to_clean: str):
         attributes={
             "*": {"style", "lang", "title", "width", "height"},
             # below are mostly defaults to ammonia, but we need to add them explicitly
-            # because this python binding doesn't allow additive whitelisting
+            # because this python binding doesn't allow additive allowing
             "a": {"href", "hreflang"},
             "bdo": {"dir"},
             "blockquote": {"cite"},