perf: move UUID validation up in pipeline #18317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemurphysf
changed the title
tiina303
reviewed
Nov 1, 2023
plugin-server/src/worker/ingestion/event-pipeline/prepareEventStep.ts
Outdated
Show resolved
Hide resolved
…sEvent` since we moved the logic
|
Looks like an existing test has a bad UUID and now fails: |
tiina303
reviewed
Nov 7, 2023
davemurphysf
force-pushed
the
dave/move-uuid-check
branch
from
a3abd5b to
26ab733
Compare
…sEvent` since we moved the logic
…thog into dave/move-uuid-check # Conflicts: # plugin-server/src/worker/ingestion/process-event.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Moving UUID validation sooner in the pipeline; no point waiting until we get to processing.
Changes
Move UUID validation from
processstep topopulateTeamDatastep👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Updated unit tests to check for bad string and null value
Also, capture.py validates the UUID here