Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added the ability to view all chart types on trends #18311

Merged
merged 4 commits into from
Nov 10, 2023
Merged

feat: added the ability to view all chart types on trends #18311

merged 4 commits into from
Nov 10, 2023

Conversation

Gilbert09
Copy link
Member

Problem

Changes

  • Includes changes to how we process the SQL results from Clickhouse - now allows us to not rely on columns being in a certain order, instead, we're now reading columns by name. Requires the top-level HogQL select to have consistent naming, but testing has been added for this

image
image
image
image

How did you test this code?

  • Some unit tests
  • Lots of clicking in chrome

@Gilbert09 Gilbert09 requested a review from a team October 31, 2023 16:55
@Gilbert09 Gilbert09 changed the title Added the ability to view all chart types on trends feat: added the ability to view all chart types on trends Oct 31, 2023
@Gilbert09 Gilbert09 force-pushed the tom/trends-persons-query branch from 49bba9b to 2cb9a09 Compare November 2, 2023 16:31
Base automatically changed from tom/trends-persons-query to master November 6, 2023 11:22
mariusandra
mariusandra approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

@Gilbert09 Gilbert09 merged commit 0d26804 into master Nov 10, 2023
64 checks passed
@Gilbert09 Gilbert09 deleted the tom/chart-displays branch November 10, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @mariusandra