Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(plugin-server): bump node-rdkafka to 2.18.0 #18283

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

bretthoerner
Copy link
Contributor

… 2.3.0) (#18228)"

This reverts commit 4756d47.

Problem

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@bretthoerner bretthoerner changed the title Revert "chore(plugin-server): bump node-rdkafka to 2.18.0 (librdkafka… revert(plugin-server): bump node-rdkafka to 2.18.0 Oct 30, 2023
@bretthoerner bretthoerner merged commit 0056a0b into master Oct 30, 2023
70 of 71 checks passed
@bretthoerner bretthoerner deleted the brett/kafka-revert branch October 30, 2023 22:58
@bretthoerner
Copy link
Contributor Author

I can't tell for sure but it feels like this is failing (pre-revert):

batchConsumer.consumer.queryWatermarkOffsets(
KAFKA_SESSION_RECORDING_SNAPSHOT_ITEM_EVENTS,
partition,
(err, offsets) => {
if (err) {
status.error('🔥', 'Failed to query kafka watermark offsets', err)
return reject()
}
resolve([partition, offsets.highOffset])
}
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant