Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map): improve dark theme styles of map #18269

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(map): improve dark theme styles of map #18269

merged 1 commit into from
Oct 30, 2023

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Dark mode for the map wasn't great (toggle required reload + attribution style).

Changes

2023-10-30 16 17 42

How did you test this code?

See gif

@thmsobrmlr thmsobrmlr requested a review from a team October 30, 2023 15:21
benjackwhite
benjackwhite approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@thmsobrmlr thmsobrmlr merged commit 211aeb2 into master Oct 30, 2023
74 checks passed
@thmsobrmlr thmsobrmlr deleted the map-dark-styles branch October 30, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thmsobrmlr @benjackwhite @daibhin