Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base 3000 homepage #18265

Merged
merged 7 commits into from
Oct 31, 2023
Merged

feat: base 3000 homepage #18265

merged 7 commits into from
Oct 31, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Oct 30, 2023

Problem

We do not want to change the functionality of the homepage in the base 3000 release

Changes

  • Re-add the recent sections & dashboard changing logic
  • Remove the "Create Insight" button in 3000 because it lives in the header
  • Cleanup some margins & padding to be tighter and more balanced

How did you test this code?

Before After
Screenshot 2023-10-30 at 12 23 08 Screenshot 2023-10-30 at 12 22 11

Non-3000 still looks good
Screenshot 2023-10-30 at 12 22 28

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin requested a review from a team October 30, 2023 15:44
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit aad00b5 into master Oct 31, 2023
74 checks passed
@daibhin daibhin deleted the dn-feat/base-3000-homepage branch October 31, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants