Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hackathon-3000): use protomap tiles from s3 #18247

Merged
merged 15 commits into from
Oct 30, 2023
Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Oct 27, 2023

Problem

We want to serve maps for the person feed from s3/a cdn via protomaps.

Changes

This PR:

  • adds protomap protocol support to maplibre-gl
  • uses pmtiles hosted from our s3 bucket as map tile source
  • uses glyphs from our s3 bucket for fonts
  • uses the cloud preflight check to determine wether to display the map
  • removes the obsolete maplibre style url setting

How did you test this code?

Tested locally

@thmsobrmlr thmsobrmlr changed the title feat(hackathon-3000): feat(hackathon-3000): use protomap tiles from s3 Oct 27, 2023
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr marked this pull request as ready for review October 27, 2023 23:32
@thmsobrmlr thmsobrmlr requested a review from a team October 28, 2023 00:12
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
More than good enough for now and we can sort out styles and things later

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) October 30, 2023 12:51
# Conflicts:
#	package.json
@thmsobrmlr thmsobrmlr merged commit ba570e1 into master Oct 30, 2023
68 of 69 checks passed
@thmsobrmlr thmsobrmlr deleted the finalize-map branch October 30, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants