feat: Add tabs for pipeline UI #18235
Conversation
tiina303
force-pushed
the
pipeline-ui-tabs-2
branch
from
9c7a21c to
7ebc12d
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
tiina303
force-pushed
the
pipeline-ui-tabs-2
branch
from
ae87312 to
2ba1ac0
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| return ( | ||
| <div className="pipeline-scene"> | ||
| <PageHeader title="Pipeline" /> | ||
| <PageHeader | ||
| title="Pipeline" |
There was a problem hiding this comment.
Should this be labeled "CDP"?
There was a problem hiding this comment.
no acronyms :) Tim & I considered that though... my vote is for pipeline
There was a problem hiding this comment.
If this is, in fact, the same product as what we have on the website, we should at least pluralize it so it partially matches: Customer Data Pipelines
There was a problem hiding this comment.
CDP = customer data platform (singular). I find pipelines weird as we don't have several atm.
| case PipelineTabs.Filtering: | ||
| return 'filter' | ||
| case PipelineTabs.Transformations: | ||
| return 'transformation' | ||
| case PipelineTabs.Destinations: | ||
| return 'destination' |
There was a problem hiding this comment.
nit: Maybe we should make these all verbs or nouns:
Option 1 (nouns): filters, transformations, destinations
Option 2 (verbs): filter, transform, export?
tiina303
force-pushed
the
pipeline-ui-tabs-2
branch
from
c46be4b to
c8bac5c
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Set up tabs and navigation on the page, so I won't get any merge conflicts working on them separately.
Note: this took way too long, we have so many different ways we do tabs in the app, this seems like the reasonable way to me, so if that's it I'll add a storybook doc for adding tabs to the scene.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?