Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Unsubscription Survey #18231

Merged
merged 10 commits into from
Nov 2, 2023
Merged

feat: Add Unsubscription Survey #18231

merged 10 commits into from
Nov 2, 2023

Conversation

xrdt
Copy link
Contributor

@xrdt xrdt commented Oct 26, 2023 •
edited
Loading

Problem

  • We would like to know why users unsubscribe. This implementation adds a survey in between the click to "unsubscribe" and submitting the unsubscription request.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @xrdt! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@xrdt xrdt requested a review from raquelmsmith October 26, 2023 19:25
@xrdt xrdt changed the title Add Unsubscription Survey chore: Add Unsubscription Survey Oct 26, 2023
@xrdt xrdt changed the title chore: Add Unsubscription Survey feat: Add Unsubscription Survey Oct 26, 2023
raquelmsmith
raquelmsmith requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add a CTA that says something like "issues with your bill? get in touch"

frontend/src/scenes/billing/BillingProduct.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/BillingProduct.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/UnsubscribeSurveyModal.tsx Outdated Show resolved Hide resolved
@xrdt xrdt force-pushed the feat/add-unsubscription-survey branch from e497bd7 to 09bde71 Compare October 27, 2023 20:44
@xrdt xrdt requested a review from raquelmsmith October 27, 2023 21:57
@xrdt
Copy link
Contributor Author

xrdt commented Oct 27, 2023 •
edited
Loading

Where can I add tests for this component? All other comments on this PR have been addressed

@xrdt xrdt force-pushed the feat/add-unsubscription-survey branch from 65937b8 to aebf461 Compare October 30, 2023 18:55
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@xrdt xrdt force-pushed the feat/add-unsubscription-survey branch from bac28d3 to 93c02b9 Compare November 1, 2023 21:46
@xrdt
Copy link
Contributor Author

xrdt commented Nov 1, 2023

Updated surveys
Screenshot 2023-11-01 at 3 54 55 PM

Screenshot 2023-11-01 at 3 55 05 PM

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@xrdt
Copy link
Contributor Author

xrdt commented Nov 2, 2023

Another iteration on the surveys

Screenshot 2023-11-01 at 5 12 45 PM Screenshot 2023-11-01 at 5 12 40 PM

@xrdt xrdt force-pushed the feat/add-unsubscription-survey branch from 9dbe90b to 6e662e9 Compare November 2, 2023 01:25
Bianca Yang added 8 commits November 2, 2023 11:15
Add unsubscription survey
3047728 
* Ask users why they're unsubscribing before they submit their unsubscription request.
update to use kea for state management, clean up some logic around fi…
66bd6e9 
…nding matching surveys
resolve typo
5057e41
pr feedback
866716d 
* CTA for contacting support in survey modal
* remove getActiveMatchingSurveys call since we can directly use the surveyID.
add storybook for billing unsubscribe survey
984748e
add basic cypress tests for the unsubscribe survey
3b01903
adding in product type as a response to our multi-question survey
3680fc1
update survey to show more information about how users might control …
d59b086 
…their costs
@xrdt xrdt force-pushed the feat/add-unsubscription-survey branch from 6e662e9 to 2681af9 Compare November 2, 2023 18:15
@xrdt xrdt requested a review from raquelmsmith November 2, 2023 18:16
raquelmsmith
raquelmsmith approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First feature, woot! Make sure you demo this in the all-hands next week 😄 and mention that it's launched (Joe likes to know for the changelog, though this isn't something he's likely to announce)

@xrdt xrdt merged commit 6c01683 into master Nov 2, 2023
70 checks passed
@xrdt xrdt deleted the feat/add-unsubscription-survey branch November 2, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyiy liyiy liyiy left review comments

@neilkakkar neilkakkar neilkakkar left review comments

@raquelmsmith raquelmsmith raquelmsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xrdt @posthog-bot @neilkakkar @raquelmsmith @liyiy