fix(groups): Fix groupsMathDefinitions with deleted group types
#18221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
tomasfarias
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #18118 we started using an array with only some values initialized for
groupTypes, so that we properly account for deleted group types in that mapping. However, it appears that the JSIterator(internal Slack thread) insist on converting the empty values toundefinedinstead of skipping (unlikeArrayitself), which TypeScript doesn't signal (well, we are abusing arrays a bit here).Changes
To fix the above, let's just use a
Mapto represent the mapping. This is better than an array, because no-longer-in-use group type indices are skipped in iteration, but also better than an object because iteration order is guaranteed.CC @tomasfarias