ci: use Depot ephemeral registry for faster pulls #18216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Oct 26, 2023
| if: needs.changes.outputs.shouldTriggerCypress == 'true' | ||
| # Build the container image in preparation for the E2E tests | ||
| uses: ./.github/actions/build-n-cache-image | ||
| id: build |
There was a problem hiding this comment.
is this just the string "build"?
There was a problem hiding this comment.
Yeah this is assigning an ID to the step so that its outputs can be referenced as outputs of the job (to eventually be passed to the depot/pull-action):
Gilbert09
pushed a commit
that referenced
this pull request
Oct 30, 2023
* ci: use Depot ephemeral registry for faster pulls * Install Depot CLI before pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current E2E tests are (1) building a container image with Depot then (2) running 20+ Cypress jobs that each run a 2nd Depot build with
load: trueto download the image result.This works, but is slow, because all the images must download from a single build host, which results in longer build times.
Changes
This PR uses a new Depot feature that allows saving a build to a Depot ephemeral registry and then pulling the image back with
depot pull <build-id>.This is faster because the Depot ephemeral registry uses a CDN to distribute layer blobs, and so does not bottleneck on EC2. Additionally, there is no charge for pull time with
depot pull.Note: I'm not entirely sure what the
production-unit.Dockerfileis, but the behavior of this PR should match what was happening before.How did you test this code?
We've tested this with our own GHA tests.