feat: drop console log events when disabled #18210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Oct 26, 2023
| @@ -95,6 +95,11 @@ type PartitionMetrics = { | |||
| lastKnownCommit?: number | |||
| } | |||
|
|
|||
| export interface TeamIDWithConfig { | |||
There was a problem hiding this comment.
added with structure since if/when we start ingesting network performance events to ClickHouse we'll want the same control
benjackwhite
approved these changes
Oct 26, 2023
Yep, I nearly added a refresher in the console log ingester 🙈 before realising we only want a little more data not twice as much 📈 |
pauldambra
commented
Oct 26, 2023
| @@ -30,9 +30,10 @@ function deduplicateConsoleLogEvents(consoleLogEntries: ConsoleLogEntry[]): Cons | |||
| const deduped: ConsoleLogEntry[] = [] | |||
|
|
|||
| for (const cle of consoleLogEntries) { | |||
| if (!seen.has(cle.message)) { | |||
| const fingerPrint = `${cle.log_level}-${cle.message}` | |||
There was a problem hiding this comment.
the only real change since last review...
Deduplication didn't work at all 🙈 🤦
benjackwhite
approved these changes
Oct 26, 2023
Gilbert09
pushed a commit
that referenced
this pull request
Oct 30, 2023
* feat: drop console log events when disabled * don't process logs before dropping them * write tests and as a result fix de-duplication * overwriting default with default is unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a team sending very large/numerous console logs in a very few session recordings. They also had long sessions.
The sessions were causing problems at ingestion and so we disabled the console log ingestion. But because their sessions were long-lived and this only affects new sessions it didn't relieve ingestion pressure.
So, we had to disable all recording for the team. So that when the teams refresher next updated we'd start dropping their recordings.
This PR amends the teams refresher to pick out (some) config for the teams so that we can still check if a team exist and is enabled for general replay ingestion - but also in the console log ingester check if a team is enabled and when there are console logs in an event drop them if the team is disabled