chore: custom lint rules #18206
Merged
chore: custom lint rules #18206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
pauldambra
approved these changes
Oct 26, 2023
| @@ -0,0 +1,3 @@ | |||
| const { rules } = require('eslint-plugin-react') | |||
|
|
|||
| module.exports = rules['forbid-elements'] | |||
| @@ -1,4 +1,4 @@ | |||
| lockfileVersion: '6.1' | |||
| lockfileVersion: '6.0' | |||
There was a problem hiding this comment.
pnpm is opaque to me... do we care about this downgrade?
There was a problem hiding this comment.
don't worry, a random PR from me will upgrade it soon anyway ☠️ , and the cycle will continue
There was a problem hiding this comment.
I can't find the exact link but I came across this in another thread recently and the tldr was that it just flapped based on a local pnpm version. Not majorly important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The warning lint rules for
react/forbid-elementsare not applied because of a duplicate key in the object. This means that the warnings never appear in filesChanges
react/forbid-elementsrule and rename itposthog/warn-elementsBased on the great work from @pauldambra in PostHog/posthog-js#843
How did you test this code?