fix(projects): reload organization after project creation #18198
Conversation
| @@ -31,6 +32,7 @@ export function CreateProjectModal({ | |||
| const handleSubmit = (): void => { | |||
| createTeam({ name, is_demo: false }) | |||
| reportProjectCreationSubmitted(currentOrganization?.teams ? currentOrganization.teams.length : 0, name.length) | |||
| loadCurrentOrganization() | |||
There was a problem hiding this comment.
Currently this is a race condition, because we are calling the non-blocking version of createTeam earlier. We could use useAsyncActions(organizationLogic) for it instead, and then call await createTeam(...) in this function, so that by the time we call loadCurrentOrganization(), we're sure that the new project actually exists by now.
However, this code basically connects two logics – it really belongs in the logics. This way if we ever call createTeam anywhere else, we won't have to remember about loadCurrentOrganization().
Let's call loadCurrentOrganization via a listener in teamLogic. Specifically, it should be a createTeamSuccess listener (every Kea loader action has *Success and *Failure companions, which are fired when loading finishes).
|
It looks like the code of @jurajmajerik: clang-format made some formatting changes here |
Problem
When project A is created, it is set to CurrentProjectButton. If project B is created immediately after (without reloading the page), project B is now set to CurrentProjectButton. Because we're not reloading the list of projects, it appears that project A disappeared/was overwritten.
Internal ticket: https://posthoghelp.zendesk.com/agent/tickets/6745
Changes
After project creation, reload the current organization (and thus the list of projects).
How did you test this code?
👀