feat(web-analytics): Add web analytics to posthog3000 #18194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
robbie-c
force-pushed
the
add-web-analytics-to-posthog3000
branch
from
007a777 to
3b45450
Compare
robbie-c
commented
Oct 25, 2023
| @@ -36,6 +36,8 @@ import { featureFlagsSidebarLogic } from './sidebars/featureFlags' | |||
| import { insightsSidebarLogic } from './sidebars/insights' | |||
| import { personsAndGroupsSidebarLogic } from './sidebars/personsAndGroups' | |||
| import { toolbarSidebarLogic } from './sidebars/toolbar' | |||
| import { IconWeb } from 'lib/lemon-ui/icons' | |||
There was a problem hiding this comment.
Not sure if this is something I should avoid? There isn't an obvious alternative here https://github.com/PostHog/icons
There was a problem hiding this comment.
It should definitely come from that repo and if there isn't a relevant one ping @corywatilo (or alternatively leave this to us as we will be adding all missing apps this sprint in one go)
There was a problem hiding this comment.
Makes sense, have pinged, but feel free to close this PR if it gets handled elsewhere :)
There was a problem hiding this comment.
Have changed this to IconPieChart temporarily
robbie-c
force-pushed
the
add-web-analytics-to-posthog3000
branch
from
3b45450 to
ff60870
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
robbie-c
force-pushed
the
add-web-analytics-to-posthog3000
branch
from
c53a023 to
16f1e45
Compare
Gilbert09
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Add web analytics to posthog 3000 * Use IconPieChart for web analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Posthog 3000 doesn't show web analytics
Changes
How did you test this code?
Ran it manually