feat: Person feed properties node #18185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/lib/constants.tsx
…-properties # Conflicts: # frontend/src/scenes/persons/PersonFeedCanvas.tsx
# Conflicts: # frontend/src/scenes/notebooks/Nodes/NotebookNodePerson.tsx # frontend/src/scenes/persons/PersonFeedCanvas.tsx
# Conflicts: # frontend/src/scenes/notebooks/Notebook/Editor.tsx # frontend/src/scenes/notebooks/Notebook/utils.ts # frontend/src/scenes/notebooks/NotebooksTable/ContainsTypeFilter.tsx # frontend/src/scenes/persons/PersonFeedCanvas.tsx # frontend/src/types.ts
benjackwhite
changed the base branch from
master
to
feat/hackathon-3000-feed-map
benjackwhite
changed the base branch from
feat/hackathon-3000-feed-map
to
master
# Conflicts: # frontend/src/scenes/notebooks/Notebook/Editor.tsx # frontend/src/scenes/notebooks/Notebook/utils.ts # frontend/src/scenes/notebooks/NotebooksTable/ContainsTypeFilter.tsx # frontend/src/scenes/persons/PersonFeedCanvas.tsx # frontend/src/types.ts
daibhin
pushed a commit
that referenced
this pull request
Oct 26, 2023
Gilbert09
pushed a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part 3 of rebase - replaces #18160
We want to show the person properties for a person.
Changes
adds a properties notebook node. similar to the map node, this node isn't built for general use yet.
Tempted to make this the same as the "person" node, and instead have options to control how it is displayed. For example I think this view looks best for narrow display, with the other looking better for wide display
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?