fix: gap cursor to insert #18163
Closed
fix: gap cursor to insert #18163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,3 +147,20 @@ export function useSyncedAttributes<T extends CustomNotebookNodeAttributes>( | |||
|
|
|||
| return [parsedAttrs.current, updateAttributes] | |||
| } | |||
|
|
|||
| export function isCustomNode(node: Node): boolean { | |||
There was a problem hiding this comment.
Reminder for myself - we can do this nicer with the canvas PR, as it autogathers all the custom components
daibhin
force-pushed
the
dn-fix/gap-cursor
branch
from
822c065 to
8ee68e7
Compare
|
Covered in #18248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current node insertion logic is buggy.
Changes
Adds a new node insertion after custom nodes
How did you test this code?