fix(batch-export-backfills): Cancel ongoing backfills on schedule delete #18136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
approved these changes
Oct 26, 2023
tomasfarias
force-pushed
the
fix/delete-backfills-on-batch-export-delete
branch
from
cac546d to
1a9adb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When users delete a BatchExport we also delete the underlying Temporal Schedule. However, we do not cancel any running backfill Workflows that may be trying to backfill the Schedule we just deleted. This leaves the Workflows hanging around waiting forever for a Schedule that doesn't exist 💔
Changes
BatchExport, also cancel any runningBatchExportBackfills.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added a unit test.