chore(p-s): add logs around setupPlugins #18099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
approved these changes
Oct 19, 2023
|
We likely don't need to load all of the plugins, just ones with processEvent <- do we load all of them? (as in we could do better filtering 🤷♀️ ) |
|
@tiina303 we already instantiate only the relevant VMs thanks to Instantiating the VM is the really costly part, so optimizing the PG query might not be the highest impact. We could indeed filter the PG query based on the |
Justicea83
pushed a commit
to Justicea83/posthog
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Let's stop blaming mmdb, this is the real reason for prod-us pods to be so slow to start.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?