feat(surveys): auto opt in and out surveys for users #18080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
requested changes
Oct 19, 2023
…sthog into remove-surveys-toggle
liyiy
commented
Oct 19, 2023
liyiy
commented
Oct 19, 2023
liyiy
commented
Oct 19, 2023
neilkakkar
reviewed
Oct 19, 2023
neilkakkar
reviewed
Oct 19, 2023
|
Fixed the flicker Screen.Recording.2023-10-19.at.4.20.21.PM.mov |
liyiy
commented
Oct 19, 2023
| @@ -33,7 +34,8 @@ interface SurveysCreators { | |||
| export const surveysLogic = kea<surveysLogicType>([ | |||
| path(['scenes', 'surveys', 'surveysLogic']), | |||
| connect(() => ({ | |||
| values: [userLogic, ['user']], | |||
| values: [userLogic, ['user'], teamLogic, ['currentTeam', 'currentTeamLoading']], | |||
| actions: [teamLogic, ['loadCurrentTeam']], | |||
There was a problem hiding this comment.
We're reloading current team to get the most up to date surveys_opt_in value since it's being triggered in the backend now.
| }, | ||
| setSurveysFilters: () => { | ||
| actions.loadSurveys() | ||
| actions.loadResponsesCount() | ||
| }, | ||
| loadSurveysSuccess: () => { |
There was a problem hiding this comment.
surveyLogic calls loadSurveys when surveys are launched/updated/resumed, so this should cover team reloading for all those cases
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
* opt in surveys when creating survey and opt out when no active surveys * update survey banner warning * add auto opt ins for surveys list launch and stop surveys * remove from onboarding step * Update UI snapshots for `chromium` (2) * update opt in from backend instead * add filter for api surveys and post delete to receiver * Update query snapshots * fix popup flicker * ambr snapshots * disabled popup banner rename * exclude api surveys in query instead --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Justicea83
pushed a commit
to Justicea83/posthog
that referenced
this pull request
Oct 24, 2023
* opt in surveys when creating survey and opt out when no active surveys * update survey banner warning * add auto opt ins for surveys list launch and stop surveys * remove from onboarding step * Update UI snapshots for `chromium` (2) * update opt in from backend instead * add filter for api surveys and post delete to receiver * Update query snapshots * fix popup flicker * ambr snapshots * disabled popup banner rename * exclude api surveys in query instead --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's pretty much no reason a user needs to manually toggle surveys functionality themselves if they want to use surveys, so we should just make it work out of the box.
Changes
Whenever a user launches a survey, we toggle the surveys script automatically for them. If they stop a survey and there are no other active surveys, we toggle the script off automatically for them.
There is still a manual option for updating the surveys toggle in
Project Settingsif the user needs to for whatever reason.A banner will also display if the user has active surveys but their toggle is turned off
Screen.Recording.2023-10-18.at.10.07.41.PM.mov
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?