-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch-exports): Add Redshift to BatchExport destinations #18059
Merged
tomasfarias
merged 18 commits into
master
from
feat/redshift-destination-for-batch-exports
Nov 1, 2023
Merged
feat(batch-exports): Add Redshift to BatchExport destinations #18059
tomasfarias
merged 18 commits into
master
from
feat/redshift-destination-for-batch-exports
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/redshift-destination-for-batch-exports
branch
from
October 19, 2023 10:42
dce972a
to
a9394ed
Compare
tomasfarias
force-pushed
the
feat/redshift-destination-for-batch-exports
branch
from
October 20, 2023 00:25
a9394ed
to
4961f88
Compare
xvello
approved these changes
Oct 20, 2023
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
tomasfarias
force-pushed
the
feat/redshift-destination-for-batch-exports
branch
5 times, most recently
from
November 1, 2023 13:37
50add8f
to
6e08239
Compare
tomasfarias
force-pushed
the
feat/redshift-destination-for-batch-exports
branch
from
November 1, 2023 16:44
6e08239
to
16f0267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users of the PostHog Redshift Export plugin need to be migrated over to PostHog batch exports to take advantage of the features provided by the new platform, and to be in line with the rest of the export destinations.
Changes
Abstract insert activity execution into a function
Not necessary for this particular issue, but I got tired of copying and pasting Workflow code. I'll follow-up with a refactor to use the function in all other workflows.
Add a
RedshiftBatchExportWorkflow
This new Workflow simply calls the Postgres activity but with Redshift-specific parameters.Since we cannot do COPY on Redshift without breaking compatibility and extra complexity, we do not use the Postgres activity anymore, but instead run an INSERT query. We do re-use as much as we can from Postgres.Add Redshift to BatchExport destinations
Model updates to support the new destination
TODO:
Frontend support for RedshiftTesting👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Locally ran unit tests: